Repository navigation
Conversation
…to bump-keyring-controller-v6
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
@metamask/keyring-controller to v6.0.0@metamask/keyring-controller to v6.0.0
NicolasMassart
left a comment
There was a problem hiding this comment.
Q: what is the word we should use consistently? SRP, Mnemonic or Seed phrase? I can see all of them in this code and not sure it's expected to be the same thing or not.
|
@jpuri I removed that patch because bumping the @OGPoyraz I have added the test cases in the PR description, let me know if there's one missing. @NicolasMassart The BIP39 spec uses the word |
Co-authored-by: Michele Esposito <34438276+mikesposito@users.noreply.github.com>
|
E2E tests executing in #9753 Edit: E2E passed for both iOS and Android ✅ |
|
Looks great! A few minor suggestions, but functionally everything looks good except maybe for the missing |
…yring-controller dependencies
…ask/metamask-mobile into bump-keyring-controller-v6
|
Smoke E2E executing in #9767 Edit: E2E passed for both iOS and Android ✅ |
|
Kudos, SonarCloud Quality Gate passed! |
|
I'll close this PR and open a new one because of a problem in GitHub. |








Description
Bump
@metamask/keyring-controllerfromv1.0.1tov6.0.0.micro-ftch+0.3.1: Added to comment out a specific node logic that was causing a compatibility issue with another library.@metamask+message-manager+7.0.1: Updated since we're using the same version for bothSignatureControllerandKeyringController.@metamask+message-manager+1.0.1: Removed@metamask+keyring-controller++@metamask+message-manager+7.3.1: Added to update the data typePersonalMessageParams.Test cases
Screenshots/Recordings
Screen.Recording.2023-07-24.at.13.33.03.mov
Issue
Fixes https://github.com/MetaMask/mobile-planning/issues/755
Checklist